sruehl commented on code in PR #1139:
URL: https://github.com/apache/plc4x/pull/1139#discussion_r1356512793
##########
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/context/SecureChannel.java:
##########
@@ -1071,7 +1070,16 @@ private void keepAlive() {
.unwrap(apuMessage ->
encryptionHandler.decodeMessage(apuMessage))
.check(p -> p.getMessage() instanceof
OpcuaOpenResponse)
.unwrap(p -> (OpcuaOpenResponse) p.getMessage())
- .check(p -> p.getRequestId() == transactionId)
+ .check(p -> {
Review Comment:
locks a bit like debugging code for me so maybe remove this from this PR and
add it to another and explain why you think that should be logged on error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
