splatch commented on code in PR #1007:
URL: https://github.com/apache/plc4x/pull/1007#discussion_r1485930252
##########
plc4go/internal/opcua/EncryptionHandler.go:
##########
@@ -131,9 +131,9 @@ func (h *EncryptionHandler) decodeMessage(ctx
context.Context, pdu readWriteMode
var message []byte
switch pduMessage := pdu.GetMessage().(type) {
case readWriteModel.OpcuaOpenResponseExactly:
- message = pduMessage.GetMessage()
+ message =
pduMessage.(readWriteModel.BinaryPayloadExactly).GetPayload()
Review Comment:
There is only one case when we expect extensible payload while parsing and
it is `CloseRequest` (which we construct). For received data we always parse
`BinaryPayload` cause this part of message might be segmented.
The extensible payload is more of a helper for generating payloads at
runtime rather than for receiving them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
