ottlukas commented on code in PR #1581:
URL: https://github.com/apache/plc4x/pull/1581#discussion_r1588917515
##########
plc4py/plc4py/drivers/modbus/ModbusConfiguration.py:
##########
Review Comment:
1. if statement with assignment:
This is a more explicit approach:
It checks if self.transport is None using the is operator.
If it is None, it assigns the string "tcp" to the self.transport
attribute.
2. Conditional assignment (or operator):
This is a more concise way to achieve the same result using the or
operator:
The expression self.transport or "tcp" evaluates to:
self.transport if it has a value other than None.
"tcp" if self.transport is currently None.
The result of the expression is then assigned to self.transport.
Choosing between them:
If clarity is a priority and you want to make the logic explicit, use the if
statement approach.
If code brevity is preferred, the conditional assignment with the or
operator is a good choice.
Both methods are valid, and the best choice depends on your coding style and
the specific context of your code.
The question of what code style we like to pursue.
Probably beeing more explicit is the way forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
