chrisdutz commented on PR #1632: URL: https://github.com/apache/plc4x/pull/1632#issuecomment-2168298153
Ok ... so it turns out that this PR had huge side-effects on protocols such as ADS, as it didn't consider uint 32 or not full short values. I had to revert the changes ... I moved the ByteOrder Helper into the modbus protocol and created a new type: ModbusByteOrder. I don't think this Word-Swap functionality is needed anywhere else than Modbus, so I would like to keep the changes there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
