Re: [PR] Adds COUNTER type for read/write.

Tue, 29 Oct 2024 05:20:54 -0700 


glcj commented on code in PR #1850:
URL: https://github.com/apache/plc4x/pull/1850#discussion_r1820691523


##########
protocols/s7/src/main/resources/protocols/s7/s7.mspec:
##########
@@ -897,6 +897,7 @@
     ['0x0B' UDINT          ['0x07'     , 'D'             , '4'               , 
'INT'                 , 'INTEGER'                          , 'IEC61131_UDINT'   
       , 'false'             , 'false'             , 'true'               , 
'true'               , 'true'              ]]
     ['0x0C' LINT           ['0x00'     , 'X'             , '8'               , 
'INT'                 , 'BYTE_WORD_DWORD'                  , 'IEC61131_LINT'    
       , 'false'             , 'false'             , 'false'              , 
'true'               , 'false'             ]]
     ['0x0D' ULINT          ['0x00'     , 'X'             , '8'               , 
'INT'                 , 'BYTE_WORD_DWORD'                  , 'IEC61131_ULINT'   
       , 'false'             , 'false'             , 'false'              , 
'true'               , 'false'             ]]
+    ['0x1C' COUNTER        ['0x1C'     , 'X'             , '2'               , 
'null'                , 'OCTET_STRING'                  , 'IEC61131_INT'        
   , 'true'              , 'true'              , 'true'               , 'true'  
             , 'false'             ]]

Review Comment:
   Hi Chris,
   
   Yes, but the enum type generated by the mspec does the magic.
   
   Attached screenshot for a DATE_AND_TIME,
   
   Best regards,
   
   
   
   
![imagen](https://github.com/user-attachments/assets/1c199008-8b14-469a-a507-604943bc1b46)
   
   
![imagen](https://github.com/user-attachments/assets/4a9bee6b-da97-432e-aa37-dcdf6768eb6a)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to