chrisdutz commented on code in PR #1833:
URL: https://github.com/apache/plc4x/pull/1833#discussion_r1866067391
##########
plc4j/drivers/modbus/src/test/java/org/apache/plc4x/java/modbus/ManualModbusTCPDriverTest.java:
##########
@@ -69,22 +92,22 @@ public ManualModbusTCPDriverTest(String connectionString) {
}
public static void main(String[] args) throws Exception {
- ManualModbusTCPDriverTest test = new
ManualModbusTCPDriverTest("modbus-tcp://192.168.23.30");
+ ManualModbusTCPDriverTest test = new
ManualModbusTCPDriverTest("modbus-tcp://10.10.1.200:10502?default-payload-byte-order=LITTLE_ENDIAN_BYTE_SWAP");
test.addTestCase("holding-register:1:BOOL", new PlcBOOL(true)); // 0001
test.addTestCase("holding-register:2:BYTE", new PlcBYTE(42)); // 2A
//test.addTestCase("holding-register:3:WORD", new PlcWORD(42424)); //
A5B8
- test.addTestCase("holding-register:4:DWORD", new
PlcDWORD(4242442424L)); // FCDE 88B8
+ test.addTestCase("holding-register:4:DWORD", new
PlcDWORD(424244242L)); // 1949 7412
Review Comment:
Yeah ... ok ... at least that's a reason I would accept ... possibly
entering it as a signed integer would work? so probably some large negative
number? (-52524872) then we wouldn't be adjusting our tests to the bugs of a
tool we use and would actually also test the boundaries of signed and unsigned
integers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
