andvasp opened a new pull request, #2016:
URL: https://github.com/apache/plc4x/pull/2016
The request is not being sent as requested in the protocol. According to the
protocol it should send the data below.
<name>Connection Request</name>
<raw>01010000000000000000000000**0400050000**000000000000000000000</raw>
But it is sending like below:
<raw>01010000000000000000000000**0000000000**00000000000000000000</raw>
The test is ok! It generates the correct request but when I execute it does
not.
Running the test, it gets the information of
[senderContext](https://github.com/apache/plc4x/blob/aaf78d9f45b4fa65dc048c87865560d046c4b47e/plc4j/drivers/ab-eth/src/main/generated/org/apache/plc4x/java/abeth/readwrite/CIPEncapsulationPacket.java#L207)
from its own test xml file
[ParserSerializerTestsuite](https://github.com/apache/plc4x/blob/d45cbf3990d43834bfe617271ef61703453bc42a/protocols/ab-eth/src/test/resources/protocols/abeth/ParserSerializerTestsuite.xml#L30-L29)
Should it be like this? I did not investigate others drivers if they behaves
the same way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
