sruehl commented on code in PR #2028:
URL: https://github.com/apache/plc4x/pull/2028#discussion_r1981381035
##########
plc4j/drivers/opcua/src/test/java/org/apache/plc4x/java/opcua/OpcuaPlcDriverTest.java:
##########
@@ -516,21 +519,24 @@ public void run() {
PlcReadResponse read_response =
read_request.execute().get();
assertThat(read_response.getResponseCode("Bool")).isEqualTo(PlcResponseCode.OK);
}
-
+ this.latch.countDown();
} catch (ExecutionException e) {
LOGGER.error("run aborted", e);
+ this.latch.countDown();
} catch (InterruptedException e) {
- Thread.currentThread().interrupt();
Review Comment:
this must stay in
##########
plc4j/drivers/opcua/src/test/java/org/apache/plc4x/java/opcua/OpcuaPlcDriverTest.java:
##########
@@ -544,11 +550,13 @@ public void run() {
PlcWriteResponse write_response =
write_request.execute().get();
assertThat(write_response.getResponseCode("Bool")).isEqualTo(PlcResponseCode.OK);
}
+ this.latch.countDown();
} catch (ExecutionException e) {
LOGGER.error("run aborted", e);
+ this.latch.countDown();
} catch (InterruptedException e) {
- Thread.currentThread().interrupt();
Review Comment:
this must stay in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
