Hi all,
I recently cleaned up the naming of all config parameters in my own drivers as
I noticed that the same thing was configured using different names in PLC4X.
I would propose to do this here too … this is the 1.0.0 release, I would like
to stop constantly renaming things with this and I guess our users are
expecting some breaking changes anyway. I’d love them to do this now and once
and not with every minor version update.
Also did I start adding the measure to the names … as some were ms and some
microseconds (my Profinet driver) … adding mostly „-ms“ makes it clear.
┌────────────────────────────────────────────────────────────┬───────────────────┬────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Current │ Proposed
│ Why
│
├────────────────────────────────────────────────────────────┼───────────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ keystore, keystore-password, keystore-type (TLS transport) │ key-store-*
│ OPC UA already uses key-store-*, and trust-store-* is hyphenated
everywhere — TLS is the outlier │
├────────────────────────────────────────────────────────────┼───────────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ timeout-request (ADS) │
request-timeout │ 15 other drivers already use that order; ADS stands alone
│
├────────────────────────────────────────────────────────────┼───────────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ tcp-no-delay, tls-version │ no-delay,
version │ Transport params are addressed <code>.<name>, so today these read
tcp.tcp-no-delay and tls.tls-version │
├────────────────────────────────────────────────────────────┼───────────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ 10 duration params │ …-ms suffix
│ So nobody opens the source to learn whether a number is seconds or millis
│
└────────────────────────────────────────────────────────────┴───────────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────┘
What do you think?
Chris
