https://issues.apache.org/bugzilla/show_bug.cgi?id=44894
Summary: [patch] move some logic from RecordFactory to
EventRecordFactory
Product: POI
Version: unspecified
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: minor
Priority: P2
Component: HSSF
AssignedTo: [email protected]
ReportedBy: [EMAIL PROTECTED]
This is some clean-up that's been due for a while. I didn't apply directly
because with the 3.1-beta release, I thought some others should perhaps
eye-ball these changes first.
RecordFactory was deprecated a while ago, (EventRecordFactory is the preferred
class) but the duplicate code has not been maintained properly. This patch is
a small step toward consolidating the list of record classes.
The biggest change is in EventRecordFactory (adding 30 odd missing record
types). In RecordFactory the method createRecord() would now call
EventRecordFactory.createRecord(). After making that initial change, much of
the old duplicate code can be deleted from RecordFactory.
BTW - Can someone please post a comment regarding the incentive behind moving
to EventRecordFactory? As far as I can understand the most important client of
this logic (HSSFWorkBook) doesn't even use it.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
