https://issues.apache.org/bugzilla/show_bug.cgi?id=50607
Yegor Kozlov <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Yegor Kozlov <[email protected]> 2011-01-19 07:31:16 EST --- Applied in r1060788 with some tweaks. Your implementation of the CLEAN function was not quite correct. According to the Excel docs, the CLEAN function removes the first 32 nonprinting characters in the 7-bit ASCII code (values 0 through 31). All other characters are not affected. This means that CLEAN does not remove any unicode characters above ASCII, including nonprinting unicode characters (values 127, 129, 141, 143, 144, and 157). I changed your code to follow Excel's rules. The ADDRESS function is actually a wrapper around org.apache.poi.ss.util.CellReference. This is a fundamental class in POI and should be cell reference operations. Your implementation has a bug and throws IndexOutOfBoundsException for columns greater than 702, i.e. Address.getColName(702) works and Address.getColName(703) fails. I removed this method and used CellReference#formatAsString instead. Other than that, very good. Thanks for the good patch! Regards, Yegor -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
