25% code coverage is fine for now. 70% would be excellent.
Yegor
On 2/4/2011 6:08 PM, Jon Svede wrote:
I don't know if this matters with respect to committing the patch but I am still
working on getting more test coverage, I am about 25% code coverage right now.
I'd like to get that number up to at least 70%.
I have not spent any time on the build integration yet, it's on my list of
things to do right after the tests.
Sincerely,
Jon
From: Nick Burch<[email protected]>
To: POI Developers List<[email protected]>
Cc: [email protected]
Sent: Fri, February 4, 2011 6:27:08 AM
Subject: Re: ExcelAnt contribution
On Fri, 4 Feb 2011, Yegor Kozlov wrote:
(1) ExcelAnt depends on ant.jar. Are we OK to include it in the compilation
classpath? It is a compile-time dependency, ant.jar is needed only to compile
the new Ant tasks and will not be included in POI distributions.
I think we should put the code into its own jar. The ant jar is then only needed
as a dependency when building that jar, so people can always exclude that target
if they want
(2) What is the proper place for this code? I propose poi-scratchpad, later we
can move it to poi-main.
I think it needs to be in its own jar. It has a dependency on ant, and I don't
think we want to add that dependency to any of the current, widely used jars.
One thing we could perhaps do is provide an ant task that generates a single
huge "poi-for-ant" jar which includes all the dependencies to make the install
easier.
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
