https://issues.apache.org/bugzilla/show_bug.cgi?id=51593
Bug #: 51593
Summary: Code Cleanup -unused imports, variables, StringBuffer
to StringBuilder conversion in toString()
Product: POI
Version: 3.8-dev
Platform: PC
Status: NEW
Severity: minor
Priority: P2
Component: HSSF
AssignedTo: [email protected]
ReportedBy: [email protected]
Classification: Unclassified
- The following variables may not be needed in the method stack ( though method
call in the same line may be needed in few cases)
In EscherChildRecordAnchor.java, Variable: bytesRemaining @ Line 40
HSSFWorkbook.java, Variable: font @ Line 1064
EncryptionInfo.java Variable: hSize @ Line 61. (This method call also may
not be needed as it is not updating any instance data)
HSSFName.java Variable: oldName @ Line 153. (This method call also may not
be needed as it is not updating any instance data)
PolygonShape.java Variable: shape @ Line 132.
EcmaDecryptor.java Variable: size @ Line 128.
- All the toString() implementations can now be updated to StringBuilder from
StringBuffer.
Currently refactored package:org.apache.poi.hssf.record.chart.* ; There are
other packages as well for which a new bug shall be raised later.
- SSTRecord.java Line 295. The same null check is being done two times.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
