+1 to enable asserts, +1 after 3.8-beta4 release By the way, just fixed some issues in code, so all HWPF tests are passes with enabled assertion.
-- Sergey On Mon, Aug 22, 2011 at 4:35 PM, Yegor Kozlov <[email protected]> wrote: > +1 to enable asserts, but only after we release 3.8-beta4. > > Yegor > > On Mon, Aug 22, 2011 at 4:10 PM, Maxim Valyanskiy <[email protected]> wrote: >> Hello! >> >> I found that HWPF code uses some assertions. Currently build.xml does not >> add "-ea" option to junit java arguments list so they are ignored on unit >> testing. I tried to enable assertions in build.xml, but it causes sereval >> test failures. That is not good, because projects that uses POI may run its >> tests with enabled assertions (that is default for maven-surefire-plugin) >> and fail to build. >> >> I think we should enable assertions in our junit runners in build.xml and >> fix all issues caused by them >> >> best wishes, Max >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Sergey Vladimirov --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
