https://issues.apache.org/bugzilla/show_bug.cgi?id=55195

            Bug ID: 55195
           Summary: MultiOperandNumericFunction.collectValue() currently
                    uses concrete final classes but should use interfaces
                    instead
           Product: POI
           Version: 3.9
          Hardware: PC
                OS: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XSSF
          Assignee: [email protected]
          Reporter: [email protected]

Currently:
if (ve instanceof NumberEval) {
    NumberEval ne = (NumberEval) ve;
    temp.add(ne.getNumberValue());
    return;
}

Instead, it should be:
if (ve instanceof NumericValueEval) {
    NumericValueEval ne = (NumericValueEval) ve;
    temp.add(ne.getNumberValue());
    return;
}

Same is true for StringEval vs. StringValueEval.

While the current approach technically works, it provides no ability to provide
custom implementations of return values from user defined functions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to