https://issues.apache.org/bugzilla/show_bug.cgi?id=55612

--- Comment #7 from Luca Della Toffola <[email protected]> ---
No problem at all, I'm happy that I could contribute.

PS: Few days back in Bugzilla 55611 I made another comment/patch after your
commit. I don't know if you had a look at it already. 

(In reply to Yegor Kozlov from comment #6)
> patched applied in r1535810
> 
> I realized I was wrong when I wrote about thread unsafety of this patch. We
> really needed synchronization in Bugzilla 55611 because
> DateUtil.isADateFormat(int, String) is static and the state of its cache
> must be synchronized. 
> 
> HSSFCellStyle.getDataFormatString() is an instance method and  we can assume
> that it is accessed from one thread ta a time. So I removed the
> synchronization lock and committed. 
> 
> Sorry if my comment caused confusion and extra work on your side. 
> 
> Regards,
> Yegor

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to