On Sun, 3 Nov 2013, Andreas Beeker wrote:
when I've added a new patch, what modifications should be done to the bugzilla entry? Currently I only change the subject to "[PATCH] ..." - should the status also be changed?
Subject of [PATCH] and status of NEW and Keywords of "PatchAvailable" and Tags of "Patch" ought to do it. Different people filter on different things, so the full set is probably safest :)
The other thing that helps is a unit test or two, any new test files that your tests need, and ensuring that all the other unit tests stay passing with your patch applied!
Also, try to avoid fixing whitespace at teh same time as fixing/adding logic. We do have somewhat of a whitespace mess in places, as we only recently finally agreed on a standard... Generally best to do 2 patches if needed, one with whitesapce only, and one with logic changes. That makes it much easer to review the patches
Usually when I try to pick a new bug to fix, I order the open bugs after priority and severity and see what could be done - apart of that, is there bug-wishlist?
We're all volunteers here, so tackle whatever interests you the most! Most of us have a few areas we're using heavily in our day jobs or personal hacking, so we tend to give bugs in those areas a lot of attention since they matter to us. We also tend to have other areas we find interesting / fun, which we keep an eye on, and particaulr things in bug reports that catch our eye and make us pay attention to the bug. Everyone is different though! Work on what matters to you, what interests you, what allows you to learn new things, and what you enjoy. The enjoying part is important - we don't want people to burn out!
If your time permits, please have a look at my open patches - I'm looking forward to your feedback ;)
Alas I'm a bit busy this week, so I won't have a chance to look myself, but hopefully others can
Non-committers - this bit's for you! If you're not a committer, we would still very much appreciate your feedback on other contributed patches. If you have time, please try applying other people's patches, and ensuring they still apply, and all tests pass. Please cast an eye over them, and ensure they make sense. Please check they have unit tests, and the tests cover the main cases, and ideally some corner cases too. Please sanity check logic changes against the file format specs.
(If we know that a patch is sane and all tests pass, we know the review will be a lot quicker. Quicker reviews are easier to schedule, so they're more likely to get applied. Patches which need lots of review have to wait for someone to have a big chunk of time to look into them with, which tends not to occur as often)
Nick --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
