https://bz.apache.org/bugzilla/show_bug.cgi?id=58245

--- Comment #3 from Javen ONeal <[email protected]> ---
Mimicking what you wrote in r1692593:
org.apache.poi.sl.usermodel.ShapeContainer: 
https://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/sl/usermodel/ShapeContainer.java?limit_changes=0&r1=1692593&r2=1692592&pathrev=1692593
org.apache.poi.xslf.usermodel.XSLFShapeContainer:
https://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFShapeContainer.java?r1=1410315&r2=1692593&pathrev=1692593

Is this what you were referring to?


ss.usermodel.Workbook:
public interface Workbook<T extends Sheet> extends Closeable, Iterable<T> {
    Iterator<T> iterator();
}

xssf.usermodel.XSSFWorkbook:
public class XSSFWorkbook extends POIXMLDocument implements Workbook<XSSFSheet>
{
    @Override
    public Iterator<XSSFSheet> iterator() {
        return sheets.iterator();
    }

hssf.usermodel.HSSFWorkbook:
public final class HSSFWorkbook extends POIDocument implements
Workbook<HSSFSheet> {
    @Override
    public Iterator<HSSFSheet> iterator() {
        return _sheets.iterator();
    }

xssf.streaming.SXSSFWorkbook:
public class SXSSFWorkbook implements Workbook<SXSSFSheet> {
    @Override
    public Iterator<SXSSFSheet> iterator() {
        return new SXSSFSheetIterator(_wb.iterator());
    }
}

I suppose I could go as far as writing a new interface:
public interface SheetContainer<T extends Sheet> extends Iterable<T>, but I
currently don't have any additional methods that a SheetContainer would need to
implement beyond what an Iterable requires.

This might be getting a bit out of my Java comfort zone here--I'm used to
Python where generics/templates aren't needed because everything is duck typed.

Suggestions?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to