Nick, I have attached a unit test and ppt file that it uses.
Azfar On Tue, Nov 17, 2015 at 2:37 PM, Nick Burch <[email protected]> wrote: > On Tue, 17 Nov 2015, Azfar Kazmi wrote: > >> I am using 3.13 and noticed that SpecialPropertySet now uses hard coded >> ASCII charset when it creates a new String out of byte[]. This change was >> introduced in September by revision 1700677. >> > > That was as part of the "forbidden APIs" cleanup, to get POI consistent > across all machines/locales > > It broke some of my test cases (where a POT file has non-ASCII characters >> in doc properties - see attached). Aren't we better off without this change >> (hence use system's default charset)? Or, better yet, why not allow user to >> provide the charset and default to ASCII if not provided? >> > > If things need turning from bytes back to Strings, would it not be better > to prompt the user to give us a String in the first place then, rather than > messing around with bytes? > > I can create a bug and patch if there's agreement on either. >> > > If we could have one of your unit tests, that'd be a big help for > understanding the use-case and current usage > > Thanks > Nick > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
hpsf_test.ppt
Description: MS-Powerpoint presentation
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
