https://bz.apache.org/bugzilla/show_bug.cgi?id=58787
--- Comment #27 from Javen O'Neal <one...@apache.org> ---
Mark,
When adding a border color, if a border line style is not set in the property
template, the code sets it. Was there any reason for using drawTopBorder rather
than directly adding the property?
> private void drawTopBorderColor(CellRangeAddress range, short color) {
> int row = range.getFirstRow();
> int firstCol = range.getFirstColumn();
> int lastCol = range.getLastColumn();
> for (int i = firstCol; i <= lastCol; i++) {
> CellAddress cell = new CellAddress(row, i);
> // if BORDER_TOP is not set on BorderPropertyTemplate, make a thin
> border so that there's something to color
> if (borderIsNotSet(cell, CellUtil.BORDER_TOP)) {
> - drawTopBorder(new CellRangeAddress(row, row, i, i),
> BorderStyle.THIN);
> + addProperty(cell, CellUtil.BORDER_TOP, BorderStyle.THIN);
> }
> addProperty(cell, CellUtil.TOP_BORDER_COLOR, color);
> }
> }
Also, what should BorderPropertyTemplate do if the border line style is set to
NONE and then drawTopBorderColor is called? Should it change the BorderStyle to
THIN?
> private boolean borderIsNotSet(CellAddress cell, String borderDirection) {
> Object borderLineStyle = getTemplateProperty(cell, borderDirection);
> - return (borderLineStyle == null);
> + return (borderLineStyle == null) || (borderLineStyle ==
> BorderStyle.NONE);
> }
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
