Deleted draw(String...). Thank you! -----Original Message----- From: Javen O'Neal [mailto:one...@apache.org] Sent: Friday, January 20, 2017 1:24 AM To: POI Developers List <dev@poi.apache.org> Subject: Re: EMF/WMF files from our regression corpus
All the EMF/WMF code is in scratchpad, is experimental, and hasn't seen a final release yet. At least until we have released 3.16 final, there's no need to @deprecated, @Deprecated, or @Removal any of the EMF code. On Jan 19, 2017 2:28 PM, "Andreas Beeker" <kiwiwi...@apache.org> wrote: > Hi Tim, > > the patch looks good - initially I thought it would be better to keep > the String version of drawString, but HwmfGraphics is the place which > combines everything, so this is good. > As this is scratchpad, please either use the full form of deprecating > (with @Removal(version)) or simply remove the methods. > > Regarding the common objects/constants ... although I had a quick view > over the EMF code, I haven't read the spec to say anything about that. > As the WMF/EMF implementations look similar, I would simply progress > to a more complete parser and eventually generalize the code. > > Thanks for your work. > > Andi > > > On 19.01.2017 17:30, Allison, Timothy B. wrote: > > That's what I thought, but I figured sharing might be helpful. > > > > Andi, > > If you have any time to review my initial commit for the wmf > > parser, > I'd appreciate it. The good parts I lifted from your emf code...the > other parts...well...sorry. :) > > There may be some areas where the emf parser could leverage some > > wmf > objects/constants...to reduce code...perhaps not, though. > > > > Onward. > > > > Thank you. > > > > Best, > > > > Tim > > > > -----Original Message----- > > From: Andreas Beeker [mailto:kiwiwi...@apache.org] > > Sent: Wednesday, January 18, 2017 6:24 PM > > To: POI Developers List <dev@poi.apache.org> > > Subject: Re: EMF/WMF files from our regression corpus > > > > Hi Tim, > > > > thank you ... although I'm currently not working on WMF, this is > > very > helpful! > > There are still a lot of features currently not implemented but I > haven't had examples for. > > > > Andi > > > > -------------------------------------------------------------------- > > - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For > > additional > commands, e-mail: dev-h...@poi.apache.org > > > > > > > > -------------------------------------------------------------------- > > - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For > > additional commands, e-mail: dev-h...@poi.apache.org > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional > commands, e-mail: dev-h...@poi.apache.org > >
