https://bz.apache.org/bugzilla/show_bug.cgi?id=60707
Dominik Stadler <dominik.stad...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #6 from Dominik Stadler <dominik.stad...@gmx.at> ---
I did a look, here some initial comments:
* The initial implementation looks already like a good start, thanks for
putting in the work
* Maybe we should throw "UnsupportedException" in the methods that are not
supported, this way the user immediately knows even if she does not look at the
JavaDoc?
* As it is complex new functionality, we might first add it to the "scratchpad"
project/source-folders so we can let it stabilise some more until we declare it
as "production ready" by moving it into the ooxml-part.
* Please remove the "// TODO Auto-generated method stub" comments with a
comment that explains why the method is empty or with an exception as stated
above or simply remove it
* Please try to format the code consistently according to our
coding-guidelines, see http://poi.apache.org/guidelines.html#CodeStyle, your
IDE will usually allow to define it and reformat a whole file in one go.
* Is there a way to not duplicate the date-formats in
StreamedSheetEventHandler? We already handle them in various places, e.g.
DateFormatConverter
* On testing I would love to see some test that kind of "trashes" the
implementation, i.e. take all spreadsheets that we have under test-data and run
the normal XSSFWorkbook/HSSFWorkbook and compare results to your implementation
as far as possible. This way we ensure that your code handles all the special
cases that can arise.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
