I'd like to see something like the array formula support run through the regression suite and common-crawl before we put it out there, as I suspect there are a lot of variations to the syntax, some of which may cause things like NPEs or other unexpected behavior. Rather than push a big change and see what happens, I'd like to see if we can pick up some additional unit tests from existing files first.
I'd also prefer it not cause a delay in 3.17 to do those things and handle any additional cases that pop up out of that testing. That said, I'm excited to see that additional support, but think it would be best to do that in 4.0 or a theoretical 3.18, where there is time for test builds, more testing, and comments before baking it in. On Wed, Aug 30, 2017 at 1:01 PM Andreas Beeker <kiwiwi...@apache.org> wrote: > sorry, I know this is a fair bit of work > > The plain release candidate creation is 3 lines of shell commands. > > The common-crawl tests are, as far as I understood Dominik, also quite > automated. > > I would object, if we would commit something big like #61469 just before > release. > > So +1 for having #61468 in 3.17. > > If no-one minds, I would create RC3 tomorrow evening. > > Andi > > > On 8/30/17 7:44 PM, Greg Woolsey wrote: > > I would like an RC3 (sorry, I know this is a fair bit of work) to pick > up r1806623 > fixing bug 61468, as I consider that a rather serious calculation bug, and > will likely cause a couple months' delay in my attempts to get > Vaadin-Spreadsheet updated to use the new conditional formatting and table > style APIs I've added to POI. > > I won't vote -1 yet, though. If others need this released now, I'm open to > a conversation about the timing of a 3.18 release. > > On Mon, Aug 28, 2017 at 2:38 PM Andreas Beeker <kiwiwi...@apache.org> > <kiwiwi...@apache.org> wrote: > > > Hi *, > > I've prepared artifacts for the release of Apache POI 3.17 (RC2). > > The most notable changes in this release are: > > - Various modules: add sanity checks and fix infinite loops / OOMs caused by > fuzzed data > - OPC: fix linebreak handling on XML signature calculation (#61182) > - SS Common: fix number formatting (github-43/52, #60422) > - SXSSF: fix XML processing - unicode surrogates and line breaks (#61048, > #61246) > > https://dist.apache.org/repos/dist/dev/poi/3.17-RC2/ > <https://dist.apache.org/repos/dist/dev/poi/3.17-RC1/> > <https://dist.apache.org/repos/dist/dev/poi/3.17-RC1/> > > > > I'll add the summary to the change log on releasing the artifacts. > > Please vote to release the artifacts. > The vote keeps open for 72hrs, 2017-09-01, 23:59 UTC, > planned release announcement date is Monday, 2017-09-04. > > Here is my +1 > > Andi > > > >
