Hello Dominik, thank you for your patch!
I've applied a modified version of it via #1874990 [1]. The reasons for my modifications are: - remove the custom CRC32 code: I don't want to mix technical code with module specific code ... thankfully it could be calculated with off the shelf CRC32 classes anyway. - use enums instead of String constants (... where we didn't have already a lot of legacy constants) - try to break the cyclomatic complexity: wherever I see lots of nested ifs, I introduce private methods to limit the scope of variables - In the ByteChunkDeferred class, the linked node can be read multiple times and we don't face exhausted InputStreams. Best wishes, Andi [1] https://svn.apache.org/viewvc?view=revision&revision=1874990 On 24.02.20 13:04, Hölzl, Dominik wrote: > Hello! > > Can somebody please have a look https://github.com/apache/poi/pull/167? > > Thank you and regards, > Dominik Hölzl > >
signature.asc
Description: OpenPGP digital signature
