jacobharris919 opened a new pull request #193: URL: https://github.com/apache/poi/pull/193
The TRUNC implementation is still broken. (BUG: https://bz.apache.org/bugzilla/show_bug.cgi?id=62506 ) 1. Bug 62506 reports that TRUNC(0.29, 2) = 0.28 2. The solution proposed in that bugfix still fails for some calculations (see test case) The main argument against the proposed fix in 62506 was the performance hit of using BigDecimal for every round() operation. Since the round() methods now use MathX methods which construct a BigDecimal from the Excel string, the TRUNC function can be fixed by using the MathX.roundDown() method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
