pjfanning commented on a change in pull request #273:
URL: https://github.com/apache/poi/pull/273#discussion_r739823404
##########
File path:
poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java
##########
@@ -875,8 +876,23 @@ public XSSFSheet createSheet(String sheetname) {
validateSheetName(sheetname);
// YK: Mimic Excel and silently truncate sheet names longer than 31
characters
+ // Issue a WARNING though in order to prevent a situation, where the
provided long sheet name is
+ // not accessible due to the trimming while we are not even aware of
the reason and continue to use
+ // the long name in generated formulas
if(sheetname.length() > 31) {
Review comment:
any chance that the 31 could be made into a shared constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
