centic9 commented on a change in pull request #275:
URL: https://github.com/apache/poi/pull/275#discussion_r742015683
##########
File path: build.gradle
##########
@@ -499,7 +533,9 @@ task allJavaDoc(type: Javadoc) {
}
-task jenkins(dependsOn: ['replaceVersion', subprojects.build,
'binDistZip','binDistTar','srcDistZip','srcDistTar']) {}
+task jenkins(dependsOn: ['replaceVersion', subprojects.build,
'binDistZip','binDistTar','srcDistZip','srcDistTar']) {
+ isCIBuild = true;
Review comment:
I actually use the "jenkins" task also locally as a "Pre-Commit-Check",
as otherwise things like "rat-check" and "javadoc" are not run and so you
potentially commit changes which break the build.
We can safely set the environment-variables as part of the CI builds via our
DSL-based approach, see
https://github.com/apache/poi/blob/trunk/jenkins/create_jobs.groovy#L264 for
the related code-based CI configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
