centic9 commented on a change in pull request #275:
URL: https://github.com/apache/poi/pull/275#discussion_r741653034
##########
File path: gradle.properties
##########
@@ -1,3 +1,15 @@
# Specifies the JVM arguments used for the daemon process.
# The setting is particularly useful for tweaking memory settings.
-org.gradle.jvmargs=-Xmx4096m
\ No newline at end of file
+# Less than 2G definitely slows things down.
+org.gradle.jvmargs=-Xmx2G -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryError
-Dfile.encoding=UTF-8
Review comment:
Previously we needed more than 2g for running all the tests, but maybe
memory requirements did change in the meantime?
Enabling heap-dump always can lead to leftover files and disk filling up in
CI, can we at least send it somewhere else, e.g. /tmp?
##########
File path: build.gradle
##########
@@ -271,8 +278,10 @@ subprojects {
'-Djavax.xml.stream.XMLInputFactory=com.sun.xml.internal.stream.XMLInputFactoryImpl',
"-Dversion.id=${project.version}",
'-ea',
- '-Djunit.jupiter.execution.parallel.config.strategy=fixed',
- '-Djunit.jupiter.execution.parallel.config.fixed.parallelism=2'
+ '-Djunit.jupiter.execution.parallel.enabled=true',
+ '-Djunit.jupiter.execution.parallel..mode.default=concurrent'
Review comment:
double dot seems incorrect
##########
File path: build.gradle
##########
@@ -499,7 +533,9 @@ task allJavaDoc(type: Javadoc) {
}
-task jenkins(dependsOn: ['replaceVersion', subprojects.build,
'binDistZip','binDistTar','srcDistZip','srcDistTar']) {}
+task jenkins(dependsOn: ['replaceVersion', subprojects.build,
'binDistZip','binDistTar','srcDistZip','srcDistTar']) {
+ isCIBuild = true;
Review comment:
I actually use the "jenkins" task also locally as a "Pre-Commit-Check",
as otherwise things like "rat-check" and "javadoc" are not run and so you
potentially commit changes which break the build.
We can safely set the environment-variables as part of the CI builds via our
DSL-based approach, see
https://github.com/apache/poi/blob/trunk/jenkins/create_jobs.groovy#L264 for
the related code-based CI configuration.
##########
File path: gradle.properties
##########
@@ -1,3 +1,15 @@
# Specifies the JVM arguments used for the daemon process.
# The setting is particularly useful for tweaking memory settings.
-org.gradle.jvmargs=-Xmx4096m
\ No newline at end of file
+# Less than 2G definitely slows things down.
+org.gradle.jvmargs=-Xmx2G -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryError
-Dfile.encoding=UTF-8
Review comment:
Thanks, if the full build via the "jenkins" task still works it should
be fine.
##########
File path: build.gradle
##########
@@ -271,8 +278,10 @@ subprojects {
'-Djavax.xml.stream.XMLInputFactory=com.sun.xml.internal.stream.XMLInputFactoryImpl',
"-Dversion.id=${project.version}",
'-ea',
- '-Djunit.jupiter.execution.parallel.config.strategy=fixed',
- '-Djunit.jupiter.execution.parallel.config.fixed.parallelism=2'
+ '-Djunit.jupiter.execution.parallel.enabled=true',
+ '-Djunit.jupiter.execution.parallel..mode.default=concurrent'
Review comment:
I'd rather keep the "jenkins" task useable and quick locally for
developers as well so we can use it as a full local "pre-commit-check".
##########
File path: build.gradle
##########
@@ -271,8 +278,10 @@ subprojects {
'-Djavax.xml.stream.XMLInputFactory=com.sun.xml.internal.stream.XMLInputFactoryImpl',
"-Dversion.id=${project.version}",
'-ea',
- '-Djunit.jupiter.execution.parallel.config.strategy=fixed',
- '-Djunit.jupiter.execution.parallel.config.fixed.parallelism=2'
+ '-Djunit.jupiter.execution.parallel.enabled=true',
+ '-Djunit.jupiter.execution.parallel..mode.default=concurrent'
Review comment:
Sorry, wrong word "useable", I rather meant to keep the env-variable as
single place which decides how to run the build.
If I run "jenkins" locally it would be good to still be able to decide if I
want to get the speedup of the parallel building.
##########
File path: build.gradle
##########
@@ -499,7 +533,9 @@ task allJavaDoc(type: Javadoc) {
}
-task jenkins(dependsOn: ['replaceVersion', subprojects.build,
'binDistZip','binDistTar','srcDistZip','srcDistTar']) {}
+task jenkins(dependsOn: ['replaceVersion', subprojects.build,
'binDistZip','binDistTar','srcDistZip','srcDistTar']) {
+ isCIBuild = true;
Review comment:
No, sorry for the confusion, it won't do harm except forcing "jenkins"
to be slower even when run locally :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
