pjfanning commented on a change in pull request #278:
URL: https://github.com/apache/poi/pull/278#discussion_r748768297
##########
File path:
poi-ooxml/src/main/java/org/apache/poi/poifs/crypt/temp/EncryptedTempData.java
##########
@@ -46,8 +46,9 @@
*/
@Beta
public class EncryptedTempData {
- private static Logger LOG = LogManager.getLogger(EncryptedTempData.class);
+ public static final SecureRandom RANDOM = new SecureRandom();
Review comment:
can you move this somewhere else? shouldn't be public in this `@Beta`
internal class
##########
File path:
poi-scratchpad/src/test/java/org/apache/poi/hslf/usermodel/TestPictures.java
##########
@@ -64,6 +64,7 @@ Licensed to the Apache Software Foundation (ASF) under one or
more
*/
public final class TestPictures {
private static final POIDataSamples slTests =
POIDataSamples.getSlideShowInstance();
+ public final static SecureRandom RANDOM = new SecureRandom();
Review comment:
why public?
##########
File path:
poi-ooxml/src/main/java/org/apache/poi/poifs/crypt/temp/EncryptedTempData.java
##########
@@ -46,8 +46,9 @@
*/
@Beta
public class EncryptedTempData {
- private static Logger LOG = LogManager.getLogger(EncryptedTempData.class);
+ public static final SecureRandom RANDOM = new SecureRandom();
+ private static Logger LOG = LogManager.getLogger(EncryptedTempData.class);
Review comment:
this should be final
##########
File path:
poi/src/test/java/org/apache/poi/ss/formula/function/ExcelFileFormatDocFunctionExtractor.java
##########
@@ -31,14 +31,7 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
import java.net.URL;
import java.net.URLConnection;
import java.security.MessageDigest;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-import java.util.Stack;
+import java.util.*;
Review comment:
can you avoid * imports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
