Thanks Marius. I submitted a PR to curvesapi - https://github.com/virtuald/curvesapi/pull/12 - and there is now a 1.07 release.
I'm still reluctant to change the poi-ooxml module-info.java unless it is proven that we need a requires clause for curvesapi. On Wednesday 19 January 2022, 04:35:48 GMT+1, Marius Volkhart <[email protected]> wrote: I don’t know the reasoning behind why we don’t need to bring in the module name for curvesapi, but curvesapi should get an automatic module name assigned by the JVM when it gets put on the modulepath, even if it doesn’t define a preferred Automatic-Module-Name. As for making it optional - given the limited support XDGF has at the moment, that seems like a reasonable thing to do. Cheers, Marius > On Jan 18, 2022, at 08:01, PJ Fanning <[email protected]> wrote: > > Hi, > I must admit to not being an expert in module-info setup. I have noticed that > curvesapi jar which is only used in some XDGF classes (poi-ooxml) does not > have module-info or Automatic-Module-Name but the poi-ooxml module-info.java > seems ok despite not having a 'requires' for this jar/module. > > Does anyone know why we don't need something in poi-ooxml module-info for > curvesapi? > > Also, since curvesapi is only used in XDGF code, would it be worth making it > an optional jar dependency? > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
