pjfanning commented on code in PR #321:
URL: https://github.com/apache/poi/pull/321#discussion_r846677479
##########
poi/src/main/java/org/apache/poi/ss/usermodel/DataFormatter.java:
##########
@@ -950,7 +950,7 @@ private String getFormattedNumberString(Cell cell,
ConditionalFormattingEvaluato
if (numberFormat == null) {
return String.valueOf(d);
}
- String formatted = numberFormat.format(d);
+ String formatted = numberFormat.format(new
BigDecimal(String.valueOf(d)));
Review Comment:
@xzel23 this is merged - it's more important that POI is correct than
lightening fast. I have profiled POI and the XSSF is really really slow and the
cause is XMLBeans and all the zip and xml parsing and writing. Number parsing
barely registers. If you use the latest JVMs, doubles and big-decimal
parsing/writing performance has improved considerably. These improvements seem
to have been added to the JVMs with little fan fair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
