https://bz.apache.org/bugzilla/show_bug.cgi?id=66532
--- Comment #4 from Matthias Raschhofer <matthias.raschho...@gmail.com> --- Thank you for your comments. I'm happy to use git, however I thought it was readonly and I should provide patches here. I opened a pull request in git (https://github.com/apache/poi/pull/443). I attached a benchmark also comparing the performance against the change made with https://github.com/apache/poi/pull/405. I think the difference is significant. I don't think there is an issue with the number of chars vs. the number of codepoints, since the loop counter is increased in case the codepoint is in fact a pair of characters. There are unit tests in the TestSheetDataWriter asserting the correct behaviour for unicode surrogates as well as the 'replaceWithQuestionMark' behaviour. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
