rascmatt commented on code in PR #443:
URL: https://github.com/apache/poi/pull/443#discussion_r1140725183
##########
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java:
##########
@@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws
IOException {
return;
}
- for (Iterator<String> iter = CodepointsUtil.iteratorFor(s);
iter.hasNext(); ) {
- String codepoint = iter.next();
+ for (int i = 0; i < s.length(); i++) {
+ final int codepoint = s.codePointAt(i);
Review Comment:
Yes, but then the codePointAt() method will not receive the correct index. I
switched to using the codePoints iterator, which does not seem to have a big
performance impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
