pjfanning commented on code in PR #477:
URL: https://github.com/apache/poi/pull/477#discussion_r1237313415
##########
poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java:
##########
@@ -297,11 +298,15 @@ public static String
getWorkbookDirEntryName(DirectoryNode directory) {
"It must be decrypted before use by XSSF, it cannot be
used by HSSF");
}
- // check for previous version of file format
- if (directory.hasEntry(OLD_WORKBOOK_DIR_ENTRY_NAME)) {
Review Comment:
Not a big deal if this is too hard but is there any chance that `hasEntry`
could remain case sensitive for backward compatibility reasons? And a new
`caseInsensitiveHasEntry` added?
If leaving `hasEntry` case sensitive is too hard, could you could not using
`directory.getEntryNames().contains` and adding a `caseSensitiveHasEntry`
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
