moalhaddar commented on code in PR #536:
URL: https://github.com/apache/poi/pull/536#discussion_r1359363306
##########
poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFRun.java:
##########
@@ -1447,6 +1566,19 @@ public enum FontCharRange {
hAnsi /* high ansi */
}
+ /**
+ * @see <a
href="https://www.ecma-international.org/publications-and-standards/standards/ecma-376/";>OOXML
Spec</a>
Review Comment:
The sections doesn't mention what a complex script is because it's something
related to the typesetting. However, these sections are titled:
- 17.3.2.2 bCs (Complex Script Bold)
- 17.3.2.17 iCs (Complex Script Italics)
- 17.3.2.38 sz (Non-Complex Script Font Size)
- 17.3.2.39 szCs (Complex Script Font Size)
and in them they specify that these properties must have an explicit tag
with it's value for them to work with complex scripts. I'm not sure if i should
include the entire paragraphs or only a link to the PDF zip file? (it's 1 file
only).
https://www.ecma-international.org/wp-content/uploads/ECMA-376-1_5th_edition_december_2016.zip
What would you suggest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
