pjfanning commented on code in PR #601:
URL: https://github.com/apache/poi/pull/601#discussion_r1507996868
##########
poi-ooxml/src/main/java/org/apache/poi/xdgf/usermodel/shape/ShapeDebuggerRenderer.java:
##########
@@ -40,9 +39,9 @@ public void setDebugAcceptor(ShapeVisitorAcceptor acceptor) {
}
@Override
- protected Path2D drawPath(XDGFShape shape) {
Review Comment:
does this compile? Regardless, I don't think we should change protected
method signatures in a patch release. Could you consider adding new private
methods and leave the protected methods alone.
##########
poi-ooxml/src/main/java/org/apache/poi/xdgf/usermodel/shape/ShapeDebuggerRenderer.java:
##########
@@ -40,9 +39,9 @@ public void setDebugAcceptor(ShapeVisitorAcceptor acceptor) {
}
@Override
- protected Path2D drawPath(XDGFShape shape) {
Review Comment:
does this compile? Regardless, I don't think we should change protected
method signatures in a patch release. Could you consider adding new private
methods and leave the protected methods alone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
