pjfanning commented on code in PR #617:
URL: https://github.com/apache/poi/pull/617#discussion_r1571420481
##########
poi-ooxml/src/main/java/org/apache/poi/ooxml/POIXMLDocumentPart.java:
##########
@@ -18,12 +18,7 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
import java.io.IOException;
import java.net.URI;
-import java.util.ArrayList;
Review Comment:
can you revert this change to this imports?
##########
poi-ooxml/src/main/java/org/apache/poi/ooxml/HyperlinkRelationship.java:
##########
@@ -0,0 +1,29 @@
+package org.apache.poi.ooxml;
Review Comment:
can you add an Apache source header here?
##########
poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/internal/marshallers/ZipPartMarshaller.java:
##########
@@ -21,20 +21,14 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
import java.io.InputStream;
import java.io.OutputStream;
import java.net.URI;
+import java.util.Objects;
import org.apache.commons.compress.archivers.zip.ZipArchiveEntry;
import org.apache.commons.compress.archivers.zip.ZipArchiveOutputStream;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.poi.openxml4j.exceptions.OpenXML4JException;
-import org.apache.poi.openxml4j.opc.PackageNamespaces;
-import org.apache.poi.openxml4j.opc.PackagePart;
-import org.apache.poi.openxml4j.opc.PackagePartName;
-import org.apache.poi.openxml4j.opc.PackageRelationship;
-import org.apache.poi.openxml4j.opc.PackageRelationshipCollection;
-import org.apache.poi.openxml4j.opc.PackagingURIHelper;
-import org.apache.poi.openxml4j.opc.StreamHelper;
-import org.apache.poi.openxml4j.opc.TargetMode;
+import org.apache.poi.openxml4j.opc.*;
Review Comment:
can you keep the existing imports - instead of using wildcards?
##########
poi-ooxml/src/test/java/org/apache/poi/openxml4j/opc/TestRelationships.java:
##########
@@ -323,10 +323,10 @@ private void assert_50154(OPCPackage pkg) throws
Exception {
PackageRelationship rId1 = drawingPart.getRelationship("rId1");
URI parent = drawingPart.getPartName().getURI();
- URI rel1 = parent.relativize(rId1.getTargetURI());
- URI rel11 =
PackagingURIHelper.relativizeURI(drawingPart.getPartName().getURI(),
rId1.getTargetURI());
- assertEquals("'Another Sheet'!A1", rel1.getFragment());
- assertEquals("'Another Sheet'!A1", rel11.getFragment());
+// URI rel1 = parent.relativize(rId1.getTargetURI());
Review Comment:
why is this commented out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
