jaragunde commented on PR #859: URL: https://github.com/apache/poi/pull/859#issuecomment-3116542189
I noticed some methods return an unmodifiableList and some don't; `XWPFParagraph.getRuns()` and `getIRuns()` are unmodifiable; `XWPFRun.getEmbeddedImages()` is not. Most methods in `XWPFDocument` return unmodifiable lists, including `getCharts()`, I should probably have followed that example. I can definitely submit a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
