pjfanning commented on PR #1044: URL: https://github.com/apache/poi/pull/1044#issuecomment-4207754471
I must admit that I'm basically -1 on this. I don't see why we should be returning empty ByteBuffers. I think we should fail when we read corrupt files. Feel free to fork POI and hack it how you please but I can't in good conscience agree to a change like this. If it was an option where this behaviour only kicks in if you set a flag on the extractor to say ignore corrupt blocks - I would possibly agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
