pjfanning opened a new pull request, #1050:
URL: https://github.com/apache/poi/pull/1050
- [x] Add tests for commit eacd5f9 (MainExtractorFactory password support)
- [x] Add `setOutputPassword` to `HSLFSlideShow` and `HSLFSlideShowImpl`
- [x] Add `setOutputPassword` to `HWPFDocumentCore`
- [x] Refactor `HSLFSlideShowEncrypted`:
- [x] Add `updateEncryptionRecord(records, password)` overload that takes
password directly
- [x] Deprecate the old `updateEncryptionRecord(records)` (which reads
from `Biff8EncryptionKey`)
- [x] Refactor `HSLFSlideShowImpl.write()`:
- [x] Remove `Biff8EncryptionKey` manipulation (set/restore)
- [x] Determine output password locally (`_outputPassword` →
`Biff8EncryptionKey` fallback, constructor password NOT used)
- [x] Call new `updateEncryptionRecord(records, password)` overload
directly
- [x] Updated javadoc and defensive copy in `setOutputPassword()`
- [x] Refactor `HSLFSlideShow.setOutputPassword()`: updated javadoc
- [x] Fix `HWPFDocumentCore.updateEncryptionInfo()`:
- [x] Remove `_password` (constructor password) from the fallback chain
- [x] Chain is now: `_outputPasswordChars` →
`Biff8EncryptionKey.getCurrentUserPassword()`
- [x] Updated javadoc and defensive copy in `setOutputPassword()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
