pjfanning commented on code in PR #1057:
URL: https://github.com/apache/poi/pull/1057#discussion_r3213166988


##########
poi-ooxml/src/main/java/org/apache/poi/openxml4j/util/ZipArchiveThresholdInputStream.java:
##########
@@ -148,7 +148,7 @@ private void checkThreshold() throws IOException {
         throw new IOException(String.format(Locale.ROOT, 
MIN_INFLATE_RATIO_MSG, payloadSize, rawSize, ratio, MIN_INFLATE_RATIO, 
entryName));
     }
 
-    ZipArchiveEntry getNextEntry() throws IOException {
+    public ZipArchiveEntry getNextEntry() throws IOException {

Review Comment:
   revert this please



##########
poi-ooxml/src/main/java/org/apache/poi/poifs/crypt/temp/AesZipFileZipEntrySource.java:
##########
@@ -130,9 +131,10 @@ private static void copyToFile(InputStream is, File 
tmpFile, byte[] keyBytes, by
         SecretKeySpec skeySpec = new SecretKeySpec(keyBytes, 
CipherAlgorithm.aes128.jceId);
         Cipher ciEnc = CryptoFunctions.getCipher(skeySpec, 
CipherAlgorithm.aes128, ChainingMode.cbc, ivBytes, Cipher.ENCRYPT_MODE, 
PADDING);
 
-        try (ZipArchiveInputStream zis = new ZipArchiveInputStream(is);
-             OutputStream fos = Files.newOutputStream(tmpFile.toPath());
-             ZipArchiveOutputStream zos = new ZipArchiveOutputStream(fos)) {
+                try (ZipArchiveInputStream zipStream = new 
ZipArchiveInputStream(is);

Review Comment:
   proper formatting please - no tabs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to