dbunner2 commented on PR #1190: URL: https://github.com/apache/poi/pull/1190#issuecomment-5147893495
Of course. It looks like #1192 took a slightly different approach. It will insert a new blank paragraph after the clearText() call whereas mine (#1190) clears the paragraph but keeps the properties by utilizing clearButKeepProperties(), matching how setText() already behaves elsewhere in this class. It is probable that #1192 would leave a stray empty paragraph at the front, since the source paragraphs get appended without removing the newly added placeholder first. With that said it is a smaller change and might be preferable if we don't care about maintaining the original paragraph's properties. Happy to close this one in favor of #1192 if you'd rather go with the smaller change, or fold any of this in. Just let me know which direction you'd like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
