pjfanning opened a new pull request, #111:
URL: https://github.com/apache/poi-xmlbeans/pull/111
`SchemaCompiler.compile` builds a `PathResourceLoader` over the `-cp`
entries — which opens a `ZipFile` per jar — and closes it on the last line of
the method:
```java
if (cpResourceLoader != null) {
cpResourceLoader.close();
}
return result;
```
Nothing guards the ~100 lines in between. If `loadTypeSystem`,
`system.save(filer)`, `generateTypes` or the extension hooks throw, every
classpath jar stays open for the life of the JVM. This is easy to hit when
scomp is driven in-process (the Maven plugin, Ant task, or a build that catches
the exception and carries on).
The body now runs in a `try/finally`. The change is almost entirely
re-indentation — `git diff -w` shows just the `try`, the `finally` and a
comment.
`compile.scomp.checkin.CompilationTests` passes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
