The GitHub Actions job "Java CI with Ant" on poi.git/leak-chunked-cipher-ctor 
has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
3784d382bf7e66aedd5f38bf036cb3579a02ac29 / PJ Fanning 
<[email protected]>
Release the temp file when ChunkedCipherOutputStream construction fails

ChunkedCipherOutputStream(DirectoryNode, int) creates a temp file and
opens an OutputStream on it, then calls the abstract
initCipherForBlock(null, 0, false), which is declared throws IOException,
GeneralSecurityException. If that throws - a bad key, an unavailable JCE
algorithm - the constructor never completes, so the caller has no
instance to close and both the open stream and the temp file are leaked.

Wrap the initCipherForBlock call so the stream is closed and the temp
file deleted before the original exception is rethrown. The field
assignments are left in place rather than reordered, so subclass
initCipherForBlock implementations still see exactly the initialisation
state they see today.

The other constructor, ChunkedCipherOutputStream(OutputStream, int), is
unaffected: it owns no temp file and wraps a stream the caller supplied.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>

Report URL: https://github.com/apache/poi/actions/runs/34116974593

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to