pjfanning commented on PR #1271:
URL: https://github.com/apache/poi/pull/1271#issuecomment-5720988700
Input names that look like cell references silently resolve to the wrong
thing. requireValidName only rejects null/blank. FormulaParser tries
cell-reference parsing before name lookup, so inputs("Q1", "FY2024", "H2") —
realistic column headers — would evaluate Q1*2 against virtual cell Q1 (blank,
or a different input if you have ≥17 inputs) with no error. The engine should
reject names that CellReference.classifyCellReference(name, version) classifies
as CELL/COLUMN/ROW, and probably names containing characters Excel forbids in
defined names (spaces, operators), which otherwise fail only at compile() with
an unhelpful parse error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]