pjfanning opened a new pull request, #1334: URL: https://github.com/apache/poi/pull/1334
Fixes https://bz.apache.org/bugzilla/show_bug.cgi?id=69977 `POIXMLUnits.parsePercent(STDepthPercent/STHPercent)` returns the percentage scaled by 1000 (so `50` and `"50%"` both come back as `50000`). The `getGapDepth`/`getGapWidth` accessors of the 3D chart data classes divide that out; the two `XDDFView3D` getters did not, so `setDepthPercent(50)` read back as `50000`. Both getters now divide by 1000, matching their setters and the sibling accessors. Test in `TestXDDFChart` covers the round trip for both properties, the `"75%"`-style form Office also writes, and unsetting. Not touched here: `XDDFDoughnutChartData.getHoleSize()` has a related asymmetry — `parsePercent(STHoleSize)` scales unit-less values by 1 but `"50%"` by 1000 — which would need a change to the public `POIXMLUnits` overload, so I left it for a separate issue. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
