pjfanning opened a new pull request, #1340: URL: https://github.com/apache/poi/pull/1340
Follow-up to https://bz.apache.org/bugzilla/show_bug.cgi?id=69154. r1918838 fixed `ColumnShifter.removalNeeded` (shipped in 5.4.0, with a test). r1918841 applied the mirror fix to `RowShifter.removalNeeded` — the overwritten area was being built with columns `0..0`, so merged regions that don't touch column A were never detected as needing removal and the region below was then shifted onto them. That change never got a test: `TestXSSFSheetShiftRows.testBug69154` actually calls `shiftColumns`. This adds the row-shift counterpart of the reported scenario to `BaseTestSheetShiftRows` so it runs for both HSSF and XSSF. Verified that with the r1918841 change reverted it fails in both with: ``` Cannot add merged region B3:C3 to sheet because it overlaps with an existing merged region (B2:B3). ``` No production code change. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
