sharanggupta opened a new pull request, #1504: URL: https://github.com/apache/poi/pull/1504
`testCreateMiniStoreFirst` calls `getNextBlock(0)` on an empty ministore inside a try with an empty catch and no `fail()`, so it passes whether or not the `IndexOutOfBoundsException` is thrown. This uses `assertThrows` like the rest of the class; if `getNextBlock` returned `END_OF_CHAIN` for an empty ministore, the old test would still pass and the new one fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
