nikhil1511 opened a new pull request, #1517:
URL: https://github.com/apache/poi/pull/1517

   ### Summary
   
   Fixes a typo in `CodePageUtil.codepageToEncoding(int, boolean)` where 
`CP_WINDOWS_1256` (`1256`, Windows Arabic) returned `"Cp1255"` (Hebrew) when 
`javaLangFormat` was `true`. The `javaLangFormat == false` branch already 
returned `"windows-1256"`.
   
   If convenient, please also consider backporting this fix to the `5.5.x` 
branch.
   
   ### Testing
   
   - Added `TestCodePageUtil#testWindows1256ArabicEncoding`.
   
   Closes #1513
   
   *Disclosure: Developed with assistance from Google Gemini (`Generated-by: 
Google Gemini`); reviewed and verified by the author.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to