nikhil1511 opened a new pull request, #1519: URL: https://github.com/apache/poi/pull/1519
### Summary Logs a warning and falls back to `ModuleMap`'s existing `WIN_1252` (`windows-1252`) default when `PROJECT_CODEPAGE` specifies a code page that `CodePageUtil` or the JVM cannot resolve, rather than aborting extraction of all modules in the file. - `windows-1252` stays within the single- and double-byte Windows code page model in [MS-OVBA 1.1](https://learn.microsoft.com/en-us/openspecs/office_file_formats/ms-ovba/7610371f-e282-4319-87c4-d5602373aaea) and matches `VBAMacroReader`'s behavior when `PROJECTCODEPAGE` is omitted. - Consistent with warning-and-continue handling for unsupported code pages in HSMF `MAPIMessage` and HPSF `Property`. If convenient, please also consider backporting this fix to the `5.5.x` branch. ### Testing - Added `TestVBAMacroReader#unsupportedProjectCodepageFallsBackToWindows1252` covering both an unmapped positive code page (`10025`) and `0`. Closes #1515 *Disclosure: Developed with assistance from Google Gemini (`Generated-by: Google Gemini`); reviewed and verified by the author.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
